Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): improve generation cycle error reporting #852

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 78.00% and no project coverage change.

Comparison is base (a1f1542) 75.36% compared to head (64d8dff) 75.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   75.36%   75.37%           
=======================================
  Files         189      189           
  Lines       13639    13680   +41     
=======================================
+ Hits        10279    10311   +32     
- Misses       2834     2840    +6     
- Partials      526      529    +3     
Impacted Files Coverage Δ
gen/schema_gen.go 81.64% <73.33%> (-0.85%) ⬇️
gen/schema_gen_sum.go 71.29% <78.57%> (-0.07%) ⬇️
gen/gen_schema.go 71.15% <100.00%> (+1.15%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the fix/improve-cyclic-error-report branch from c4b4b86 to 64d8dff Compare April 10, 2023 08:22
@ernado ernado merged commit 7bce11d into ogen-go:main Apr 10, 2023
@tdakkota tdakkota deleted the fix/improve-cyclic-error-report branch April 13, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants